Skip to content

Add 341 release notes#4976

Merged
martint merged 1 commit intotrinodb:masterfrom
martint:relnotes
Sep 8, 2020
Merged

Add 341 release notes#4976
martint merged 1 commit intotrinodb:masterfrom
martint:relnotes

Conversation

@martint
Copy link
Copy Markdown
Member

@martint martint commented Aug 26, 2020

Closes #4755

@martint martint added the WIP label Aug 26, 2020
@cla-bot cla-bot bot added the cla-signed label Aug 26, 2020
@martint martint added this to the 341 milestone Aug 26, 2020
@martint martint force-pushed the relnotes branch 3 times, most recently from 12cb36c to fefef8a Compare September 2, 2020 16:42
@martint martint removed the WIP label Sep 3, 2020
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Improve latency of lazy dynamic filters in some cases"? Or maybe just drop

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "Improve latency when dynamic filtering is in use" ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop it. It's too vague.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is less about performance than about cost. We used to fetch 128 partitions per API call to Glue. We now fetch 1000. The query planning performance difference with and without patch was ~<5s (out of around 3m planning time, so... negligible).

This does lower cost and help avoid running into rate-limits. Not sure how that should be conveyed in release notes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hashhar how about

* Decrease the number of requests to the Glue metastore when fetching partitions.
  This helps avoid hitting rate limits and decreases service costs. ({issue}`4938`)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, not hitting a rate-limits does help performance.

Copy link
Copy Markdown
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a huge release. A lot of items.

@martint martint force-pushed the relnotes branch 6 times, most recently from a84d805 to 37878f4 Compare September 4, 2020 20:37
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "fractional seconds" a valid term?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes (vs "whole seconds"). What feels weird about it?

@martint martint force-pushed the relnotes branch 3 times, most recently from c13e42f to 20c6e75 Compare September 8, 2020 19:44
Copy link
Copy Markdown
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of date with the new microsecond changes. Any tables containing timestamps need to be rewritten entirely. It's actually a different PR number, since the microsecond PR would cause such tables to be completely different.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the suggestion? Remove it?

@martint martint closed this Sep 8, 2020
@martint martint deleted the relnotes branch September 8, 2020 23:57
@martint martint merged commit 3271fb9 into trinodb:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Release notes for 341

10 participants